Anagha Mercado
Anagha Mercado
As per discussion with Lars - keep issue, but not a high priority
Moved issue over to chainweb-node (103)
➤ [email protected] commented: Estimated at 5 days on spreadsheet, so adding that estimation in here for now
➤ Lars Kuhtz commented: When we have time it would be nice to do some benchmarks and see the effect of the different changes. I am particularly curious about the...
➤ Lars Kuhtz commented: 👍 for using IntMap IntSet in place of HM.HashMap Int (HS.HashSet Int).
➤ Colin Woodbury commented: > I am particularly curious about the effect of adding laziness. It's less GHC laziness and more Massiv's internal "Delayed" representation. Using D properly improves performance...
➤ Lars Kuhtz commented: > type AdjacencySets = HM.HashMap Int (HS.HashSet Int) This type is actually only used to convert between DiGraph and the matrix representation. So, it has to...
➤ Colin Woodbury commented: It does seem to be used: fromAdjacencySets :: AdjacencySets -> DenseAdjMatrix fromAdjacencySets g = makeArray Seq (n :. n) go where n = HM.size g go...
➤ Lars Kuhtz commented: > fromAdjacencySets :: AdjacencySets -> DenseAdjMatrix That's just the conversion function between the DiGraph representation and the the representation that is used in the Floyd-Warshall algorithm....
➤ Colin Woodbury commented: Exactly, if DiGraph needs the signature that it currently has, then we'd waste time converting to IntMap IntSet anyway.