lolstaticdata icon indicating copy to clipboard operation
lolstaticdata copied to clipboard

Inconsistent use of underscores and camelCase in served JSON

Open russ3llc opened this issue 2 years ago • 4 comments

The hosted JSON at http://cdn.merakianalytics.com/riot/lol/resources/latest/en-US/items and http://cdn.merakianalytics.com/riot/lol/resources/latest/en-US/items.json has inconsistent use of underscores and camelCase in keys. E.g. Some items use "attackDamage" while others use "attack_damage".

This was acknowledged in the code in Issue #29, but was actually resolved from what I can tell. However, the served JSON still has those inconsistencies.

I used a Python script to standardize this for the combined items JSON. Script: https://1drv.ms/u/s!Ak6LaqWhKRfWhKJlkXwLAB4XtlREYg?e=I1KZKA New JSON: https://1drv.ms/u/s!Ak6LaqWhKRfWhKJnw9VEN0oabXqIDA?e=6Ym7Iv

russ3llc avatar Sep 19 '22 04:09 russ3llc

Oh, and for some reason Equinox (7023) Ornn isn't listed as a "requiredAlly".

russ3llc avatar Sep 19 '22 04:09 russ3llc

Making this change would likely break any apps that are using this data. We will fix this the next time there are major breaking changings to the format of the JSON file.

jjmaldonis avatar Oct 08 '22 18:10 jjmaldonis

Makes sense. Thanks!

russ3llc avatar Oct 08 '22 18:10 russ3llc

I'm going to keep this open so I don't forget :)

jjmaldonis avatar Oct 08 '22 19:10 jjmaldonis