lolstaticdata
lolstaticdata copied to clipboard
Inconsistent use of underscores and camelCase in served JSON
The hosted JSON at http://cdn.merakianalytics.com/riot/lol/resources/latest/en-US/items and http://cdn.merakianalytics.com/riot/lol/resources/latest/en-US/items.json has inconsistent use of underscores and camelCase in keys. E.g. Some items use "attackDamage" while others use "attack_damage".
This was acknowledged in the code in Issue #29, but was actually resolved from what I can tell. However, the served JSON still has those inconsistencies.
I used a Python script to standardize this for the combined items JSON. Script: https://1drv.ms/u/s!Ak6LaqWhKRfWhKJlkXwLAB4XtlREYg?e=I1KZKA New JSON: https://1drv.ms/u/s!Ak6LaqWhKRfWhKJnw9VEN0oabXqIDA?e=6Ym7Iv
Oh, and for some reason Equinox (7023) Ornn isn't listed as a "requiredAlly".
Making this change would likely break any apps that are using this data. We will fix this the next time there are major breaking changings to the format of the JSON file.
Makes sense. Thanks!
I'm going to keep this open so I don't forget :)