cassiopeia icon indicating copy to clipboard operation
cassiopeia copied to clipboard

Riot LOL API matchV5 coming

Open Alexntf opened this issue 4 years ago • 2 comments
trafficstars

Hey,

Have you seen that Riot will update the API with more data?

  • getMatch http://riot.com/36SP9B6
  • getTimeline https://t.co/TjHxmbxDAK?amp=1
  • full info https://mobile.twitter.com/RiotTuxedo/status/1358914005679497216 Will cass will be updated?

Hope you all safe <3

Alexntf avatar Feb 09 '21 11:02 Alexntf

Well v5 is expected to be launched in Q2, but eventually it will be updated (hopefully), depending how busy are the maintainers. What about you making a PR for that ? possible ehh @Alexntf

ianhco avatar Feb 09 '21 20:02 ianhco

Hey! We did see that! Pretty cool that they are adding data. It looks like the updates are purely additive, no modifications or removals, and the new data is a handful of new participant stats + a handful of new timeline events.

We will be updating this, but we also welcome PRs like paaksing said. The PRs should be pretty straightforward to write. I doubt I will get to the code within the week that the data is released, so if someone really wants to get the data asap they will probably have to make a PR for us. Otherwise we will certainly do it within the 90-day grace period, and hopefully within 30 days or a week. The changes shouldn't really be that bad though so hopefully sooner.

jjmaldonis avatar Feb 09 '21 23:02 jjmaldonis

I'm going to close this. We do not fully support all the new data, but the code is working with v5.

jjmaldonis avatar Oct 07 '22 20:10 jjmaldonis