komanda icon indicating copy to clipboard operation
komanda copied to clipboard

Use sass/less/etc

Open tyscorp opened this issue 10 years ago • 6 comments

This would make creating themes a LOT easier, as you'd only have to tweak a few colours in most cases.

tyscorp avatar Jun 23 '14 01:06 tyscorp

Does node-webkit already have CSS variables ?

MoOx avatar Jun 23 '14 07:06 MoOx

@MoOx even if it does, e.g. SASS provides useful functionality that won't ever be in CSS officially anyway.

I personally use SCSS all the time and would have no problem with using a preprocessor but unless it's 100% necessary (it may be, the CSS can get kinda verbose at times) we don't have to do this right now.

eugene-bulkin avatar Jun 27 '14 05:06 eugene-bulkin

@eugene-bulkin fyi, it's Sass, not SASS. I used to use Sass everywhere, but now I'm using a good naming convention, and the only things I miss are variables (because now, we do have math, thanks to calc). But now I use myth, a futurproof way to use native CSS syntax, even if not totally implemented in all browsers.

And for theming something like Komanda, using simples variables should be more than enough.

MoOx avatar Jun 27 '14 05:06 MoOx

That's true, but mixins are also very useful. I don't really care either way.

eugene-bulkin avatar Jun 27 '14 22:06 eugene-bulkin

My opinion may be pretty unpopular but I don't care much for abstractions. If you use css classes properly I don't really see the purpose in variables, mixins etc. I look at sass/less etc like I look at coffeescript.. pointless crap push on the community via rails.

Also,, the whole nested css selector stuff is a nightmare to me.

djcas9 avatar Jul 19 '14 20:07 djcas9

With that said.. if the community wants it thats another story.. if variables will make themeing easier.. maybe we just create a boilerplate css templates people can use?

djcas9 avatar Jul 19 '14 20:07 djcas9