meow icon indicating copy to clipboard operation
meow copied to clipboard

CI: package-lint optional dependency issues (which-key)

Open eshrh opened this issue 1 year ago • 3 comments

CI error: Error: You should depend on (emacs "30.1") if you need `which-key--create-buffer-and-show'.

which-key was added to emacs 30.

Relevant (?):

  • https://github.com/meow-edit/meow/blob/e5817f3b5ef82cbcf8a729af205191dc6b142282/meow-shims.el#L389-L408
  • https://github.com/purcell/package-lint/issues/281
  • https://github.com/purcell/package-lint/issues/125
    • purcell seems to be of the opinion that you should put each shim into a different, small package. I'm honestly inclined to agree, but it obviously involves a nonzero amount of more work.

Either way, something needs to be done about the package-lint error... recent commit (a159b743d2b3c4fa17d13e90a4c753325c320afa) was a naive attempt to quickly silence the problem but I quickly realized there's a bigger problem here. Warrants more discussion, hence this issue.

package-lint also doesn't like all the eval-after-loads in the shims but that's a different problem (or maybe not, idk)

eshrh avatar Apr 04 '25 19:04 eshrh

Would you be open to considering tools like Cask or Eask? They provide more flexibility for tasks such as building, linting, and testing, which might give us more options to work around this issue—for example, temporarily disabling certain checks. 🤔

I'd be happy to help integrate the CI workflow into the project if that would be helpful. 😊

jcs090218 avatar Aug 01 '25 11:08 jcs090218

I have very little knowledge about CI workflow, I'm open to these tools.

DogLooksGood avatar Aug 01 '25 16:08 DogLooksGood

I've opened a PR in #761 that reproduces the same error, but for now, I've moved it into its own step with continue-on-error: true enabled. What do you think of this workaround? 🤔

jcs090218 avatar Aug 02 '25 16:08 jcs090218