facebook-api-android-aar icon indicating copy to clipboard operation
facebook-api-android-aar copied to clipboard

Attach Sources

Open blundell opened this issue 11 years ago • 6 comments

Currently when I click through to the source, it asks me to attach them. (i.e. cmd+click on LoginButton).

Would be nice in the readme to add this to the gradle script, or update the AAR internally.

https://github.com/facebook/facebook-android-sdk

blundell avatar Dec 30 '13 12:12 blundell

What changes are you talking about? If automatic attach of the sources it depends on IDE you're using. If it's Android Studio there's no way to automatically attach sources in gradle script (known to me). IDEA automatically attaches sources if available.

mente avatar Dec 30 '13 12:12 mente

Ah ok, just before when I have done maven repo releases, you can also release the sources jar, therefore when you do "attach sources" it can look them up in the same repo location.

blundell avatar Dec 30 '13 13:12 blundell

Check #4, sources should be available

mente avatar Dec 30 '13 13:12 mente

Hm, looks like there were changes in Android Studio. I've verified working of sources with some 0.3.x version. With latest 0.4.0 sources are not available anymore. Not sure what can I do here. Sources are working as expected. Just use example pom.xml to verify

<project>
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.mycompany.app</groupId>
  <artifactId>my-module</artifactId>
  <version>1</version>

  <repositories>
    <repository>
      <id>github-facebook</id>
      <name>Facebook github</name>
      <layout>default</layout>
      <url>http://mente.github.io/facebook-api-android-aar</url>
    </repository>
  </repositories>

  <dependencies>
    <dependency>
      <groupId>com.facebook</groupId>
      <artifactId>facebook-android-sdk</artifactId>
      <version>3.6.0</version>
      <type>aar</type>
    </dependency>
  </dependencies>
</project>

mente avatar Dec 30 '13 13:12 mente

Yeah I'm on 0.4.0 with Gradle :+1: good to know it's not just me

blundell avatar Dec 30 '13 15:12 blundell

I've posted the question to Android Team. You can follow the progress there.

mente avatar Dec 30 '13 17:12 mente