cyvlfeat icon indicating copy to clipboard operation
cyvlfeat copied to clipboard

exposed vl_phow

Open simmimourya opened this issue 8 years ago • 8 comments

Fixed Errors.

simmimourya avatar Jun 05 '16 16:06 simmimourya

Can one of the admins verify this patch?

menpobot avatar Jun 05 '16 16:06 menpobot

I would suggest that for methods like rgb2gray or equivalent where it is likely they will have more widespread use that we move them into a utils package or something.

Also, now would be a great time to add a test so we can check that everything is actually working correctly. The easiest thing to do is probably to run the phow function in Matlab on the Lena image. You will probably want to save the Lena image down from Python to ensure the pixel values are identical (and we don't get mixed up by Matlab vs Python image reading. Also, note that the Matlab output will be fortran ordered so you may need to do some transposing to get the shape correct.

patricksnape avatar Jun 06 '16 14:06 patricksnape

To Do:

  • [ ] Fix Line 82 descrs[si] = np.concatenate((d[:]), axis=0)
  • [ ] Add test for vl_phow

simmimourya avatar Jun 07 '16 17:06 simmimourya

@simmimourya1 The CI builds are failing because of the cyvlfeat.sift.tests.sift_test.test_phow_frames_float_descriptors test. So you might want to take a look at it.

devkhan avatar Jun 11 '16 16:06 devkhan

@devkhan Thanks for the suggestion. I'll check it.

simmimourya avatar Jun 11 '16 17:06 simmimourya

  • [ ] Add function doc-string in phow() and rgb2gray().
  • [ ] Add more test cases.

simmimourya avatar Jun 13 '16 13:06 simmimourya

@simmimourya1 Why did you delete this?

patricksnape avatar Jun 23 '16 09:06 patricksnape

Can one of the admins verify this patch?

menpobot avatar Jun 25 '16 07:06 menpobot