fieldmask-utils icon indicating copy to clipboard operation
fieldmask-utils copied to clipboard

Tutorial on how to convert a protobuf message and filter certain fields to a resulting map.

Open marcoshuck opened this issue 1 year ago • 3 comments

This PR addresses the discussion raised in #41

I ended up copying the CamelCase code from the function to my personal open source project to avoid code duplications due to the limitation of the github protobuf project being deprecated, we can remove the dependency if it doesn't make sense to keep it in here.

marcoshuck avatar Jan 31 '24 03:01 marcoshuck

Seems CI pipelines are failing, looking into it.

marcoshuck avatar Jan 31 '24 03:01 marcoshuck

Seems CI pipelines are failing, looking into it.

Yeah, i think i need to upgrade the dependencies and the go version. I'll do that in a separate PR.

mennanov avatar Feb 01 '24 17:02 mennanov

Seems CI pipelines are failing, looking into it.

Yeah, i think i need to upgrade the dependencies and the go version. I'll do that in a separate PR.

I ended up not upgrading the go version in go.mod since it may impact the existing users of the library as according to the docs (https://go.dev/doc/modules/gomod-ref#go):

Go toolchains refuse to use modules declaring newer Go versions.

I updated Github Actions tests for go 1.21 though.

mennanov avatar Feb 04 '24 15:02 mennanov

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2de6178) 89.27% compared to head (05ee728) 89.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   89.27%   89.27%           
=======================================
  Files           2        2           
  Lines         401      401           
=======================================
  Hits          358      358           
  Misses         27       27           
  Partials       16       16           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 12 '24 16:02 codecov[bot]

Thanks for contributing!

mennanov avatar Feb 15 '24 06:02 mennanov