MengXi

Results 46 comments of MengXi

And the test fail is because `amax` function which committed here https://github.com/unifyai/ivy/commit/c69258d556492d7d4c8c3dc9be531a4111d3857c Can I ask that if there is anything I should do for it?

add_frontend_checklist

> To streamline the review process a little bit, would you mind making a comment with `add_frontend_checklist` in it? > This will generate a checklist for you that you can...

## Frontend Task Checklist #### IMPORTANT NOTICE 🚨: The [Ivy Docs](https://unify.ai/docs/ivy/) represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item...

> @Crayon-ShinChan yup, just without the having it wrapped as code 😅. I've edited your comment but sadly it won't trigger our bot to fill the checklist. Can do you...

> Please check on anything you think you have completed (or should skip), and I'll review it accordingly. Sorry for the vague instructions at first 😅 I should have told...

> Awesome work @Crayon-ShinChan 🚀🚀 > > Your PR is almost ready to merge but few changes need to be made first. Please look into the points I left them...

> Awesome work @Crayon-ShinChan 🚀🚀 > > Your PR is almost ready to merge but few changes need to be made first. Please look into the points I left them...

I implement the logic in another lib `next-intl` https://github.com/amannn/next-intl/issues/88#issuecomment-1791936419 maybe can be a inspiration

> Does the `fallbackLocale` option in `createI18nClient` / `createI18nServer` helps in this situation? > > > > https://github.com/QuiiBz/next-international/blob/68bc9b147c85ce29a9e7d717cfa3ae52ddb1db90/examples/next-app/locales/client.ts#L22 > > > > Or do you wish to be able to...