AppStoreWidgetBoilerplate icon indicating copy to clipboard operation
AppStoreWidgetBoilerplate copied to clipboard

Test project does not belong in the source code

Open Andries-Smit opened this issue 8 years ago • 3 comments

All widgets have test projects. That is a really good thing. Much of an improvement.

However a test project... is not code, and to keep the commit clean, the test projects should actually not part of the widget source repository.

Mendix projects have their own SVN repository where they belong, but they are not publicly accessible for others.

Is there a good solution for splitting the 2?

Andries-Smit avatar Jan 13 '17 09:01 Andries-Smit

Nope. We're going to create a new one for Mendix 6, but this should be a part of it in my opinion. Yes, a lot of widgets are created for a particular project and don't need a test-project, but for those that go in the AppStore we'd like one so we can test it's functionalities. That's why it should be part of the repository.

You have other suggestions?

JelteMX avatar Jan 17 '17 09:01 JelteMX

And the test-project is not part of the source code, in that regard. Like package.json and Grunt/Gulp are not part of the source code. The source code lives in the src folder

JelteMX avatar Jan 17 '17 09:01 JelteMX

They are binary files, so they don't add anything on the diffs. The biggest challenge is that they pollute the commits. Lots of .svn stuff .jar files and .java files etc.

What I do like about it that they are matching with the version.

Ideally, they would live in their own SNV repo (Sprintr) that is public and connected with the package.

Andries-Smit avatar Jan 17 '17 12:01 Andries-Smit