mendhak
Waveshare module for Raspberry Pi 3B+
First, thanks or doing this! It's kinda cool. ;-)
Using a RPi 3B+ I had to change a few things in the e-Paper sub git. My changes can be found here, which are a few things that were needed to get my 7.5V2 display to output correctly. Hopefully the commit message is clear describing where the changes came from.
Given that you are not the original author of the e-Paper support code I was planning on sending a pull request to the vendor git. Assuming they are even receptive to PR's / changes. In their defense, everything worked fine from their tarball on the wiki. (https://www.waveshare.com/wiki/7.5inch_HD_e-Paper_HAT#Working_With_Raspberry_Pi) Or would you be receptive to taking my changes in your repo as this is where I saw the breakage but not in their demos.
Thoughts, comments, opinions ?
I think it makes more sense to introduce the changes to the waveshare vendor so it means no drift over in this repo over time, which is bound to happen.
But then why is the breakage happening, is the code in their git repo actually out of date, or is the submodule in this repo pointing at an old commit.
I do have the submodule pointing at the latest in the master branch, surely that ought to be enough?
[submodule "lib/e-Paper"]
path = lib/e-Paper
url = https://github.com/waveshare/e-Paper.git
ignore = dirty
branch = master
This is enough for your purposes, but since that repo from what I can tell and see, doesn't support the RPi3B+ which is what I am using. If you are interested in supporting the RPi3B+ and zero we could potentially keep them in separate branches. Unfortunately I have not heard anything back from waveshare in regards to the dual support in their repo.
Here is the diff which shows the RPi3B+ vs. RPiZero. Unfortunately my Python game is pretty weak so I am not really in a position to offer advice on how to support both boards in the same code base.
I suspect the vendor doesn't really want to support the RPi3B+ anymore as it is old as dirt. So what I did for simplicity is create a new branch just for the 3B+ .
Oh I understand now. I think making that branch makes sense, and if someone specifically wants it, they can clone that as a submodule instead of waveshare's own. What I will do is change this thread's title so it's easier to find in case someone wants it