angular-intro.js icon indicating copy to clipboard operation
angular-intro.js copied to clipboard

bower.json should be updated to point to the right file

Open k3v3n opened this issue 8 years ago • 8 comments

The latest version broke our build because it doesn't point to the right "main" file. The latest 3.2.1 version point to an undefined file "main": "src/angular-intro.js". Maybe it should be "main": "dist/angular-intro.min.js" ? Will stay to 3.1.3 version until it's fixed.

k3v3n avatar Mar 27 '17 19:03 k3v3n

i didn't noticed that, i'm sorry.

it happened because angular-intro.js as been deprectable as we changed to typescript.

the right one is "src\ng-intro.component.js" and the minified "build\angular-intro.min.js" i didn't change to "dist" folder because it may broke for others.

working on it

millerscout avatar Mar 28 '17 14:03 millerscout

thanks for the feedback.

millerscout avatar Mar 28 '17 14:03 millerscout

I saw that your package.json was not reflecting your latest changes to.

k3v3n avatar Mar 28 '17 15:03 k3v3n

@k3v3n thanks! i'm merging the fix

millerscout avatar Mar 28 '17 17:03 millerscout

@k3v3n i created a new release may you check if everything is running safe and sound?

millerscout avatar Mar 28 '17 17:03 millerscout

It seems that your bower.json point to a file that does not exist src/ng-intro.component.js Have you forgot to publish it ?

k3v3n avatar Apr 04 '17 17:04 k3v3n

Hmm nope I'll change that, as we use typescript, that .js. File is compiled on grunt.

As soon as I get home I'll check what can* be done

millerscout avatar Apr 04 '17 21:04 millerscout

#125 merged the fixed bower.json file

millerscout avatar Apr 05 '17 00:04 millerscout