electrs icon indicating copy to clipboard operation
electrs copied to clipboard

Remove maxfeerate safeguard from sendrawtransaction API

Open mononaut opened this issue 1 year ago • 2 comments

This PR sets the maxfeerate parameter in the sendrawtransaction RPC call to zero to allow transactions with any fee rate to be broadcast via the /broadcast and POST /tx REST APIs

(see https://bitcoincore.org/en/doc/26.0.0/rpc/rawtransactions/sendrawtransaction/)

mononaut avatar Apr 19 '24 17:04 mononaut

At the same time, fees are getting up to like 10% of the default limit now, so a spike might tip them over the hard coded default...

Maybe we should be calculating the fee estimates on electrs side so we can have access to them and pass in the limit as a multiple of the low priority rate (less volatile). Maybe 500x.

junderw avatar Apr 20 '24 14:04 junderw

We should just let users provide the maxfeerate themselves in the API request (and enforce the existing default otherwise), like the new testmempoolaccept endpoint.

This PR was a last minute thing for some customers anticipating problems during the halving madness.

mononaut avatar Apr 20 '24 15:04 mononaut