nanosvg icon indicating copy to clipboard operation
nanosvg copied to clipboard

start versioning nanosvg.

Open talregev opened this issue 1 year ago • 5 comments

Can you add version number to releases of nanosvg?

talregev avatar Mar 21 '23 22:03 talregev

As a distro maintainer for Arch Linux, I agree it would be great to at least get some semver git tags.

svenstaro avatar Jun 21 '23 03:06 svenstaro

It would also be great to have an SOVERSION in the compiled shared libraries.

I currently do this with the fltk fork (that one is required by PrusaSlicer):

Index: nanosvg-fltk_2022-12-22/CMakeLists.txt
===================================================================
--- nanosvg-fltk_2022-12-22.orig/CMakeLists.txt
+++ nanosvg-fltk_2022-12-22/CMakeLists.txt
@@ -22,6 +22,10 @@ target_link_libraries(nanosvgrast PUBLIC
 target_include_directories(nanosvgrast PRIVATE src)
 target_compile_definitions(nanosvgrast PRIVATE NANOSVGRAST_IMPLEMENTATION)
 
+# Add soversion
+set_property(TARGET nanosvg SOVERSION 0)
+set_property(TARGET nanosvgrast SOVERSION 0)
+
 # Installation and export:
 
 include(CMakePackageConfigHelpers)

bnavigator avatar Jul 09 '23 14:07 bnavigator

@bnavigator You should create a PR. Thank you!.

talregev avatar Jul 09 '23 15:07 talregev

Would it make at difference?

https://github.com/memononen/nanosvg/blob/9da543e8329fdd81b64eb48742d8ccb09377aed1/README.md?plain=1#L1

bnavigator avatar Jul 09 '23 17:07 bnavigator

I think it is. As you see, my comment is attract many attention.

talregev avatar Jul 09 '23 17:07 talregev