mage icon indicating copy to clipboard operation
mage copied to clipboard
verified publisher icon memgraph

Bring back removed modules

Open imilinovic opened this issue 1 year ago • 2 comments

Description

Making query modules removed under v1.14.1 available again.

TODOs

  • [x] Put the modules back
  • [ ] Move all tests from host to Docker under reusable_test.yml
  • [ ] Make sure the release pipeline is also working (don't mess with promotion from RC to release yet)

Pull request type

  • [ ] Bugfix
  • [ ] Algorithm/Module
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • [ ] Core algorithm/module implementation
  • [ ] Query module implementation
  • [ ] Tests provided (unit / e2e)
  • [ ] Code documentation
  • [ ] README short description

Documentation checklist

  • [ ] Add the documentation label tag
  • [ ] Add the bug / feature label tag
  • [ ] Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • [ ] Write a release note, including added/changed clauses
    • [Release note text]
  • [ ] Link the documentation PR here
    • [Documentation PR link]
  • [ ] Tag someone from docs team in the comments

imilinovic avatar Oct 03 '24 17:10 imilinovic

Removal happened under https://github.com/memgraph/mage/pull/443 under Dockerfile.release -> starting from memgraph v2.21, the modules should start working (fix done under https://github.com/memgraph/memgraph/pull/2347) -> revert the change done under v1.14.1 of Mage 😄

gitbuda avatar Oct 04 '24 10:10 gitbuda

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Oct 24 '24 15:10 sonarqubecloud[bot]

@imilinovic Can we close this? We've recently merged multiple PRs (540, 535) that decoupled parts of this PR related to updating dependencies and modules. We've also opened PR 546 to handle dockerized testing.

DavIvek avatar Feb 10 '25 11:02 DavIvek

Closing because this is done under other PR

gitbuda avatar Feb 24 '25 14:02 gitbuda