mage icon indicating copy to clipboard operation
mage copied to clipboard

Fix building of newly created rust modules

Open Josipmrden opened this issue 1 year ago • 1 comments

Description

New query modules could not be built in Rust because there was a logical error in the code.

Pull request type

  • [X] Bugfix
  • [ ] Algorithm/Module
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • [ ] Core algorithm/module implementation
  • [ ] Query module implementation
  • [ ] Tests provided (unit / e2e)
  • [ ] Code documentation
  • [ ] README short description

Documentation checklist

  • [X] Add the documentation label tag
  • [X] Add the bug / feature label tag
  • [X] Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • [X] Write a release note, including added/changed clauses
    • Fixed logical error when building new Rust query modules
  • [X] Link the documentation PR here
    • No PR needed
  • [X] Tag someone from docs team in the comments @kgolubic

Josipmrden avatar Jun 22 '24 13:06 Josipmrden

As Release note I'l use:

  • Fixed building of newly created Rust query modules. Previously, there was a logical error in the code that prevented new Rust query modules from being built correctly. #483

kgolubic avatar Jul 01 '24 14:07 kgolubic