mage icon indicating copy to clipboard operation
mage copied to clipboard

Add periodic iterate fix on authentication

Open Josipmrden opened this issue 2 years ago • 6 comments

Description

Periodic iterate has not been able to execute queries in an authenticated environment because on one of the paths the client has been connecting to Memgraph without username and password provided. That path has now been covered to provide credentials based on environment variables.

Pull request type

  • [X] Bugfix

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

Josipmrden avatar Nov 01 '23 20:11 Josipmrden

@antejavor please create a community issue for this so engineering team can take this over

Josipmrden avatar Nov 09 '23 15:11 Josipmrden

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 28 '23 20:11 sonarqubecloud[bot]

@Josipmrden I have added the initial issue to the community projects.

antejavor avatar Nov 29 '23 14:11 antejavor

RN: Periodic iterate is now executed in an authenticated environment as expected.

vpavicic avatar Dec 05 '23 08:12 vpavicic

@Josipmrden is this PR fixing the issue + if it is, does it fix other similar issues too? https://github.com/memgraph/mage/issues/424

katarinasupe avatar Jan 11 '24 13:01 katarinasupe

@Josipmrden is this a part of the 2.14 release or should I just remove the milestone? :D

vpavicic avatar Jan 12 '24 10:01 vpavicic

@Josipmrden what is status with this PR?

antoniofilipovic avatar Mar 13 '24 10:03 antoniofilipovic

With v2.16, this is now fixed by another PR

Josipmrden avatar Apr 12 '24 09:04 Josipmrden