mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Added deeplake support

Open rupeshbansal opened this issue 2 years ago • 4 comments

Description

Adds support for activelake deeploop

from embedchain.vectordb.deeplake import DeeplakeDB
from embedchain.config.vectordb.deeplake import DeeplakeDBConfig
from embedchain import App
app = App(db=DeeplakeDB(config=DeeplakeDBConfig(path="/tmp/deeplake")))

Fixes #694

Type of change

Please delete options that are not relevant.

  • [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • [ ] Unit Test

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

rupeshbansal avatar Oct 24 '23 11:10 rupeshbansal

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Files Coverage Δ
embedchain/config/__init__.py 100.00% <ø> (ø)
embedchain/config/vectordb/deeplake.py 100.00% <100.00%> (ø)
embedchain/factory.py 93.02% <ø> (ø)
embedchain/vectordb/deeplake.py 86.11% <86.11%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.

codecov[bot] avatar Oct 25 '23 14:10 codecov[bot]

Hi @rupeshbansal Can you please resolve the conflicts, so we can test the PR?

Dev-Khant avatar Jun 15 '24 10:06 Dev-Khant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rupesh Bansal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 26 '24 02:07 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rupesh Bansal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 26 '24 02:07 CLAassistant

Hi @rupeshbansal can you please resolve the merge conflicts?

Dev-Khant avatar Aug 01 '24 20:08 Dev-Khant

thanks for your contribution Rupesh Closing this PR as the code has changed a lot and there are merge conflicts.

taranjeet avatar Aug 03 '24 05:08 taranjeet