mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Adressing issue: Rename apps/Llama2App.py to follow snake case conven…

Open Ayesha-Imr opened this issue 2 years ago • 1 comments

…tion #665

Description

The issue: Rename apps/Llama2App.py to follow snake case convention #665 has been addressed.

Fixes (issue)

The relevant file, class and variable names have been renamed to snake case and references to these names in other files have also been modified.

  • [ ] Refactor (does not change functionality, e.g. code style improvements, linting)

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] My changes generate no new warnings
  • [ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #665

Ayesha-Imr avatar Oct 15 '23 07:10 Ayesha-Imr

@Ayesha-Imr can you please do a minor fix so that builds pass? I think you have to make the change here: https://github.com/embedchain/embedchain/blob/main/embedchain/init.py#L7

deshraj avatar Oct 15 '23 07:10 deshraj

@Ayesha-Imr Can you please check the above conversations and resolve the conflict so we can review and merge?

Dev-Khant avatar Jun 04 '24 10:06 Dev-Khant

Thanks for your contribution @Ayesha-Imr . Will have to close this PR as there are so many merge conflicts and the code is not relevant now.

taranjeet avatar Jun 17 '24 00:06 taranjeet