mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Add octoAI LLM support

Open KapilM26 opened this issue 2 years ago • 3 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (does not change functionality, e.g. code style improvements, linting)
  • [ ] Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • [ ] Unit Test
  • [ ] Test Script (please provide)

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

KapilM26 avatar Sep 28 '23 01:09 KapilM26

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Files Coverage Δ
embedchain/config/llm/base_llm_config.py 94.87% <100.00%> (+0.27%) :arrow_up:
embedchain/apps/OctoAIApp.py 0.00% <0.00%> (ø)
embedchain/llm/octoai.py 0.00% <0.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.

codecov[bot] avatar Oct 03 '23 13:10 codecov[bot]

Can't test this yet because OctoAI is having issues

KapilM26 avatar Oct 03 '23 13:10 KapilM26

@KapilM26 can you please rebase the PR and test with OctoAI?

deshraj avatar Dec 22 '23 10:12 deshraj

@KapilM26 Can you please test the functionality now and resolve the merge conflicts?

Dev-Khant avatar Jun 10 '24 05:06 Dev-Khant

Closing this PR since been inactive for long time. @KapilM26 feel free reopen.

deshraj avatar Jun 17 '24 15:06 deshraj