mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

bug: `docs_site` loader does not work

Open cachho opened this issue 2 years ago • 2 comments

🐛 Describe the bug

Test code:

from embedchain import App
from embedchain.config import ChromaDbConfig, AppConfig

app = App(AppConfig(log_level="DEBUG"),chromadb_config=ChromaDbConfig(chroma_settings={"allow_reset": True}))
app.db.reset()
app.add("https://docs.zextras.com/carbonio-ce/html/general.html#what-is-product")

cachho avatar Sep 15 '23 13:09 cachho

@deshraj @cachho Here when I checked for our docs it worked because quickstart was present in all_urls that are fetched in _get_child_links_recursive() of docs_site_loader.py.

image

But for the given URL in the above code. This current path == carbonio-ce/html/general.html in not present in all_urls and that's why no URL is selected and no data is loaded.

image image

So here to make sure that the given path is present in all_url can we append the current_path to the list? The link response is checked before, so there won't be any issue of a given link not working.

Dev-Khant avatar Sep 18 '23 09:09 Dev-Khant

Hi @deshraj @cachho any update on this?

Dev-Khant avatar Sep 29 '23 06:09 Dev-Khant