mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Add non-GCP PALM providers

Open Mark-Zeng opened this issue 2 years ago • 1 comments

Description

Add new LLM and embedding providers for PALM (non-GCP)

Fixes #480

Type of change

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Documentation update

How Has This Been Tested?

Since the new embedder and llm uses API, the test is done manually by adding data and sending queries.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #480
  • [ ] Made sure Checks passed

Mark-Zeng avatar Sep 07 '23 05:09 Mark-Zeng

Thanks @Mark-Zeng for the contribution. I reviewed the PR and it looks good in general apart from small bugs.

You can fix these bugs by cherry picking this commit in your PR: https://github.com/embedchain/embedchain/commit/d2a3acdafb6b50b913f81db85cfaa7aea29ab64b

Also, please rebase after cherry picking so that we can merge your PR. Thanks!

deshraj avatar Oct 06 '23 20:10 deshraj

@Mark-Zeng Can you please resolve the merge conflicts so we can merge the PR?

Dev-Khant avatar Jun 04 '24 06:06 Dev-Khant

Closing this PR because of inactivity.

deshraj avatar Jun 24 '24 17:06 deshraj