mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Add `wikipedia` as a `DataType`

Open ianupamsingh opened this issue 2 years ago • 3 comments

Description

This PR includes changes to add wikipedia as a DataType by using wikipedia PyPI package

Fixes #212

Type of change

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Documentation update

How Has This Been Tested?

It has been tested locally

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

ianupamsingh avatar Aug 25 '23 07:08 ianupamsingh

Thanks for putting this up. From a quick glance, the support for auto-inferring the Wikipedia datatypes also needs to be added in https://github.com/embedchain/embedchain/blob/d0956a0dc1952126398a48fd4647d81eb56de5ed/embedchain/utils.py#L118

rupeshbansal avatar Aug 25 '23 07:08 rupeshbansal

Can you resolve the merge conflict and deal with the requested changes please? Let me know if you want us to take over. thanks.

cachho avatar Sep 04 '23 08:09 cachho

@ianupamsingh can you please resolve the conflicts so that we can merge this PR?

deshraj avatar Dec 22 '23 09:12 deshraj

@ianupamsingh Can you please resolve the merge conflicts so we can merge this PR?

Dev-Khant avatar Jun 04 '24 06:06 Dev-Khant

Thanks for your contribution @ianupamsingh . This is a great one. Will have to close this as it has become stale and wikipedia can be handled by using web_page as the data type.

taranjeet avatar Jun 17 '24 00:06 taranjeet