mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

fix(vector_stores): Unexpected return value on MilvusDB

Open Zynoo71 opened this issue 7 months ago • 1 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • [x] Test Script (please provide)

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

Zynoo71 avatar May 21 '25 08:05 Zynoo71

Bug Reproduction

`

use MilvusDB as vector_store

memory = Memory.from_config(config)
memory.add(
    messages="i don't like curry now",
    user_id="default_user",
)
print(memory.get_all(user_id="default_user"))

`

I checked the function declaration, MilvusDB.list should return List[OutputData] but now return [ List[OutputData] ]

Zynoo71 avatar May 21 '25 08:05 Zynoo71

@Zynoo71 can you resolve merge conflicts? And can you check for the other vectorstore the output is consistent throughout the vectorstores and this is what it's supposed to be.

parshvadaftari avatar Sep 01 '25 14:09 parshvadaftari

@Zynoo71 can you share the output for all the memory functions? Thanks

parshvadaftari avatar Sep 05 '25 12:09 parshvadaftari