mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Fix/2614 response error for reasoning model in Memory.add

Open ygsharma opened this issue 8 months ago • 2 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • [x] Unit Test

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

ygsharma avatar May 06 '25 09:05 ygsharma

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 06 '25 09:05 CLAassistant

I don't have the issue with <think>...</think> in the response from the llm anymore, I have a feeling that I had an out-of-date openai client installed. At some point I ran make install_all and that would have updated it to a version that properly parses the <think>...</think> content into the message.reasoning field.

johnwlockwood avatar May 12 '25 19:05 johnwlockwood

@ygsharma Can you remove the changes made in pyproject.toml and resolve the merge conflicts?

parshvadaftari avatar Aug 22 '25 19:08 parshvadaftari