mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

feat: Add option to disable asynchronous memory addition in completio…

Open lfcunha07 opened this issue 1 year ago • 1 comments

Description

This change introduces an option to disable asynchronous memory addition in the completion.create method. This new feature allows developers to control memory behavior during the conversation, enabling synchronous memory addition for more predictable and controlled operation in specific use cases.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (does not change functionality, e.g. code style improvements, linting)
  • [ ] Documentation update

How Has This Been Tested?

This feature was tested by toggling the new option and observing whether memory addition occurs synchronously during the completion process. All tests passed with the new flag both enabled and disabled, showing consistent behavior across different scenarios.

  • [x] Unit Test
  • [ ] Test Script (please provide)

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

lfcunha07 avatar Jan 07 '25 22:01 lfcunha07

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 07 '25 22:01 CLAassistant

@lfcunha07 Can you check the commits. There seems to missing files as there are no significant changes.

parshvadaftari avatar Aug 19 '25 11:08 parshvadaftari

Closing this PR as stale.

parshvadaftari avatar Oct 10 '25 22:10 parshvadaftari