mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

The collect_metrics option for the app is not taken into account in all actions.

Open Panczo opened this issue 1 year ago • 1 comments

🐛 Describe the bug

According to your docs, collect_metrics app option allows to turn off sending telemetry data. However looking at file embedchain this is correct only for add and delete methods.

    def delete(self, source_id: str):
        ...
        # Send anonymous telemetry
        if self.config.collect_metrics:
            self.telemetry.capture(event_name="delete", properties=self._telemetry_props)

Why for the remaining methods there is no check and instead telemetry data is send?

    def query(
     ...

        # Send anonymous telemetry
        self.telemetry.capture(event_name="query", properties=self._telemetry_props)

Panczo avatar Jul 21 '24 22:07 Panczo

Hey @Panczo Good suggestion, please feel free to work on it.

Dev-Khant avatar Aug 02 '24 13:08 Dev-Khant