mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

[refactor] pass config object instead of pass db/ef params

Open gasolin opened this issue 2 years ago • 2 comments

alternative proposal to replace https://github.com/embedchain/embedchain/pull/100

  1. pass config object instead of pass separate params (db, ef), which is expected to extend more
  2. add default_model in config time (could add another method to overwrite in query time though)

gasolin avatar Jul 05 '23 13:07 gasolin

We're currently discussing which route to take for configuration. I agree that it needs to change from how it is right now.

cachho avatar Jul 05 '23 13:07 cachho

take a look at #156 and PR #158, that's most likely the route were taking for configuration.

cachho avatar Jul 06 '23 15:07 cachho

replaced by #158

gasolin avatar Jul 07 '23 00:07 gasolin