mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Fix #892: migrated from pytube to yt-dlp

Open MoizKhuzema opened this issue 8 months ago • 27 comments

Description

I addressed issue #892 that states pytube has an issue where it will refuse to download a video saying it is age restricted even though it is not https://github.com/pytube/pytube/issues/1712 . yt-dlp does not have that problem and actually returns more data about the video. To solve this, i used poetry remove pytube and poetry install yt-dlp to migrate. All tests were passed successfully

Fixes # (issue) Fix/ #892

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

used this script for testing: from embedchain import Pipeline as App import os

os.environ["OPENAI_API_KEY"] = "xxx"

app = App() app.add('https://www.youtube.com/watch?v=4cUtpiDwU0s', data_type='youtube_video') app.query("What is the video about?")

Please delete options that are not relevant.

  • [x] Test Script (please provide)

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

MoizKhuzema avatar Jun 09 '24 17:06 MoizKhuzema