mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Premai SDK integration

Open Anindyadeep opened this issue 1 year ago • 3 comments
trafficstars

Description

This PR adds a integration of premai python sdk to embedchain llms and embedder.

Fixes #1366 Fixes #1368

Type of change

  • [X] New feature: Added premai python sdk
  • [X] Documentation update to add premai python sdk
  • [X] Schema validation support for custom llms and embedding models

How Has This Been Tested?

I have added tests and those are passing. You can also checkout this documentation part to reproduce it.

Please delete options that are not relevant.

  • [X] Unit Test
  • [X] Test Script ( here )

Checklist:

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] My changes generate no new warnings
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [X] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

Anindyadeep avatar May 15 '24 11:05 Anindyadeep

Hi @deshraj, it would be great, if we can start the review process for this, so that I can re-iterate.

Thanks and appreciate it.

ps: the code was very readible, devex experience was awesome with embedchain :)

Anindyadeep avatar May 20 '24 17:05 Anindyadeep

Hi @deshraj, just checking, if we can move on to the review process, since this PR is open for quite a while now. Thanks

Anindyadeep avatar Jun 10 '24 07:06 Anindyadeep

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: Anindyadeep
:x: Anindyadeep Sannigrahi


Anindyadeep Sannigrahi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 26 '24 02:07 CLAassistant

Hey @Anindyadeep thanks for your contribution. There are a lot of merge conflicts that needs to be resolved and we haven't heard back from you in a while. So closing this.

taranjeet avatar Aug 03 '24 05:08 taranjeet