mem0ai
LanceDB Integration
Description
This PR adds LanceDB vector database.
Type of change
- [x] New feature (non-breaking change which adds functionality)
How Has This Been Tested?
I have written tests for the LanceDB vector database in tests/vectordb/test_lancedb.py
- [x] Test Script (please provide)
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] New and existing unit tests pass locally with my changes
- [x] I have checked my code and corrected any misspellings
Maintainer Checklist
- [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
- [ ] Made sure Checks passed
@PrashantDixit0 thanks for proposing these changes. I had a look at your code. There are 2 minor problems with the imports.
embedchain/config/vectordb/lancedb.py:
please correct the import line to
from embedchain.helpers.json_serializable import register_deserializable
tests/vectordb/test_lancedb.py: please correct import line to:
from embedchain.config import AppConfig
from embedchain.config.vectordb.lancedb import LanceDBConfig
Further, lancedb is not yet added to the factory.py and the misc.py. Can you add this?
@LeonieFreisinger Thank you for highlighting it, I have added these changes. Is it now good to merge?
@PrashantDixit0 What example did you use to test your code? Can you provide me with a quick example and a sample config? Thanks. Could you also add an example to the docs?
Sure @LeonieFreisinger, I'll add an example notebook in notebooks folder
@LeonieFreisinger, I have added an example notebook and tested the whole flow. Is it good to merge?
