mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Clarifai : Added Clarifai as LLM and embedding model provider.

Open mogith-pn opened this issue 1 year ago • 14 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • [x] Unit Test
  • [x] Test Script (please provide)

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

mogith-pn avatar Mar 11 '24 14:03 mogith-pn

@mogith-pn can you please run poetry lock --no-update so that the poetry.lock file is updated? Seems like the CI is failing because of this.

deshraj avatar Mar 12 '24 19:03 deshraj

@deshraj Thanks for the quick review. I have executed poetry lock --no-update and committed the changes. Please take a look into it.

mogith-pn avatar Mar 13 '24 12:03 mogith-pn

@deshraj , Addressed linting issues, could you please re-run the workflows. TIA :)

mogith-pn avatar Mar 15 '24 14:03 mogith-pn

@deshraj , I have adjusted the test code, meanwhile I couldn't able to run the tests locally, I'm getting the following error RuntimeError: Session factory is not initialized. Call setup_engine() first. error.

mogith-pn avatar Mar 19 '24 16:03 mogith-pn

@mogith-pn can you try to run rm -rf ~/.embedchain and try running tests again? It should work then

deshraj avatar Mar 20 '24 18:03 deshraj

@mogith-pn can you try to run rm -rf ~/.embedchain and try running tests again? It should work then

Thanks @deshraj ! Please take a loot at it now. I have fixed the errors.

mogith-pn avatar Mar 21 '24 12:03 mogith-pn

Seems like there are some lint issues. Can you please fix it by running make lint format

deshraj avatar Mar 21 '24 20:03 deshraj

@deshraj Apologies ! Addressed the lint issues.

mogith-pn avatar Mar 22 '24 08:03 mogith-pn

Still seeing the issue:

embedchain/vectordb/qdrant.py:3:8: F401 [*] `uuid` imported but unused

Can you please remove the UUID import? Thanks!

deshraj avatar Mar 22 '24 16:03 deshraj

@deshraj Is it really needed, because when i ran poetry run ruff . I'm getting all checks passed as result. And I also noticed there's an existing PR which addresses this ?

mogith-pn avatar Mar 23 '24 17:03 mogith-pn

Yeah, can you please fix it in your PR? We won't be able to merge the PR unless the CI checks pass.

deshraj avatar Mar 26 '24 15:03 deshraj

Yeah, can you please fix it in your PR? We won't be able to merge the PR unless the CI checks pass.

Hi @deshraj , The issue is fixed, could you please re-run the CI. TIA :)

mogith-pn avatar Apr 01 '24 13:04 mogith-pn

Yeah, can you please fix it in your PR? We won't be able to merge the PR unless the CI checks pass.

Hi @deshraj , The issue is fixed, could you please re-run the CI. TIA :)

Hey @deshraj , Hope you are doing well. Could you please initiate re-run for the tests. TIA :)

mogith-pn avatar Apr 12 '24 17:04 mogith-pn

Hi @deshraj / @taranjeet , Could you please re-initiate the workflow ? Thanks :)

mogith-pn avatar Apr 16 '24 18:04 mogith-pn

Hi @mogith-pn Can you resolve the conflicts so that it can be merged?

Dev-Khant avatar Jun 04 '24 10:06 Dev-Khant

Hi @mogith-pn Can you resolve the conflicts so that it can be merged?

Hey @Dev-Khant, could you please check this now ?

mogith-pn avatar Jun 04 '24 12:06 mogith-pn

@mogith-pn Please fix this conflicts, once it's done we can run the tests and merge this.

Dev-Khant avatar Jun 10 '24 05:06 Dev-Khant

@Dev-Khant , Resolved conflicts.

mogith-pn avatar Jun 10 '24 10:06 mogith-pn

Hi @mogith-pn Can you please check why the tests are failing?

Dev-Khant avatar Jun 10 '24 12:06 Dev-Khant

Hi @mogith-pn Can you please check why the tests are failing?

@Dev-Khant , Sorry my bad, there's inconsistency between poetry.lock and pyproject.toml ! Fixing it.

mogith-pn avatar Jun 10 '24 12:06 mogith-pn

@Dev-Khant , Kindly check now !

mogith-pn avatar Jun 10 '24 13:06 mogith-pn

@mogith-pn Thanks a lot for quickly responding and making fixes. Sorry for the delay in running CI build tests. @deshraj will review this ASAP and it will be merged.

Thanks a lot for contributing!

Dev-Khant avatar Jun 10 '24 14:06 Dev-Khant

@mogith-pn Thanks a lot for quickly responding and making fixes. Sorry for the delay in running CI build tests. @deshraj will review this ASAP and it will be merged.

Thanks a lot for contributing!

Sure, Happy to contribute ! Looking forward to it.

mogith-pn avatar Jun 10 '24 14:06 mogith-pn

@mogith-pn Can you please resolve conflicts with poetry?

Dev-Khant avatar Jun 14 '24 05:06 Dev-Khant

@deshraj @Dev-Khant , Made changes ! Please take a look into it.

mogith-pn avatar Jun 14 '24 10:06 mogith-pn

Codecov Report

Attention: Patch coverage is 21.42857% with 55 lines in your changes missing coverage. Please review.

Project coverage is 54.37%. Comparing base (4800e03) to head (f02f958). Report is 2 commits behind head on main.

Files Patch % Lines
embedchain/embedder/clarifai.py 0.00% 37 Missing :warning:
embedchain/llm/clarifai.py 46.87% 17 Missing :warning:
embedchain/vectordb/qdrant.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
- Coverage   54.73%   54.37%   -0.36%     
==========================================
  Files         160      162       +2     
  Lines        6404     6473      +69     
==========================================
+ Hits         3505     3520      +15     
- Misses       2899     2953      +54     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 14 '24 12:06 codecov[bot]