mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

[Bugfix] fix llm chat with using session_id as args for referring history

Open memeyeop opened this issue 1 year ago • 1 comments

Description

fix llm chat with using session_id as args for referring history

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • [x] Unit Test

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

memeyeop avatar Jan 17 '24 04:01 memeyeop

@memeyeop The session_id has no use in chat() method. Why do you think this needs to be done?

deven298 avatar Jan 18 '24 08:01 deven298

This is not needed anymore actually. Hence, closing this PR.

deshraj avatar Jun 05 '24 17:06 deshraj