mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Ruff: Add ASYNC checks

Open cclauss opened this issue 1 year ago • 3 comments

https://docs.astral.sh/ruff/rules/#flake8-async-async

examples/rest-api/main.py:77:22: ASYNC101 Async functions should not call open, time.sleep, or subprocess methods

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (does not change functionality, e.g. code style improvements, linting)
  • [ ] Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • [ ] Unit Test
  • [ ] Test Script (please provide)

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

cclauss avatar Jan 08 '24 02:01 cclauss

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0de9491) 56.12% compared to head (063374b) 56.12%. Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1139   +/-   ##
=======================================
  Coverage   56.12%   56.12%           
=======================================
  Files         135      135           
  Lines        5445     5445           
=======================================
  Hits         3056     3056           
  Misses       2389     2389           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 08 '24 08:01 codecov[bot]

@cclauss thanks for the PR. Can you please resolve the conflicts so that we can review the PR?

Thank you for your time.

deshraj avatar Jan 08 '24 18:01 deshraj

@deshraj Rebased.

cclauss avatar Jan 09 '24 10:01 cclauss