mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

#1128 | Remove deprecated type hints from typing module

Open sssserrano opened this issue 1 year ago • 3 comments

Description

Remove deprecated type hints from typing module

Fixes #1128

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [X] Unit Test

Checklist:

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [X] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #1128
  • [ ] Made sure Checks passed

sssserrano avatar Jan 07 '24 12:01 sssserrano

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0373fa2) 56.08% compared to head (42f5b63) 56.12%. Report is 2 commits behind head on main.

Files Patch % Lines
embedchain/helpers/callbacks.py 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
+ Coverage   56.08%   56.12%   +0.04%     
==========================================
  Files         135      135              
  Lines        5440     5445       +5     
==========================================
+ Hits         3051     3056       +5     
  Misses       2389     2389              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 07 '24 12:01 codecov[bot]

@sandrasgg looks like these conflicts are ther after I merged your previous PR. Can you please resolve these so that we can review the code? Thanks!

deshraj avatar Jan 08 '24 18:01 deshraj

@deshraj I've rebased with main and resolved the conflicts, it's ready to be reviewed 👌🏼

sssserrano avatar Jan 08 '24 19:01 sssserrano