mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Small improvements

Open sssserrano opened this issue 1 year ago • 1 comments

Description

  • Replace deprecated logging.warn with logging.warning
  • Replace unnecessary instance methods with static methods
  • Fix typos
  • Fix return types and doc strings
  • Replace argument names that shadow built-in keywords with trailing (according to PEP8 naming style)
  • Remove unnecessary parenthesis
  • Fix argument signature in load_data method in BaseLoader
  • Simplify boolean comparisons
  • Remove unused config_info variables

Type of change

  • [X] Refactor (does not change functionality, e.g. code style improvements, linting)
  • [X] Documentation update

How Has This Been Tested?

  • [X] Unit Test

Checklist:

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [X] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx
  • [ ] Made sure Checks passed

sssserrano avatar Jan 07 '24 11:01 sssserrano

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (1b661bb) 56.17% compared to head (31ee87b) 56.34%. Report is 8 commits behind head on main.

Files Patch % Lines
embedchain/loaders/github.py 60.00% 4 Missing :warning:
embedchain/store/assistants.py 0.00% 4 Missing :warning:
embedchain/embedder/google.py 0.00% 2 Missing :warning:
embedchain/loaders/image.py 0.00% 2 Missing :warning:
embedchain/vectordb/zilliz.py 33.33% 2 Missing :warning:
embedchain/embedchain.py 83.33% 1 Missing :warning:
embedchain/llm/google.py 0.00% 1 Missing :warning:
embedchain/loaders/directory_loader.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   56.17%   56.34%   +0.16%     
==========================================
  Files         134      134              
  Lines        5362     5392      +30     
==========================================
+ Hits         3012     3038      +26     
- Misses       2350     2354       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 07 '24 11:01 codecov[bot]