gen_rmq icon indicating copy to clipboard operation
gen_rmq copied to clipboard

Change unix precision to seconds for timestamp property

Open sakshamgupta05 opened this issue 4 years ago • 1 comments

The timestamp property in AMQP 0-9-1 is defined as a 64bit Unix timestamp, which is seconds since 1970/1/1 For reference -> https://github.com/rabbitmq/rabbitmq-message-timestamp/issues/16#issuecomment-314799434

This causes issues while reading in some of the client libraries which assume that the value is in seconds & parses this value incorrectly Example, java client library -> https://github.com/rabbitmq/rabbitmq-java-client/blob/23e7ba0e96d383c80f8da2fb23786a1111854f9a/src/main/java/com/rabbitmq/client/impl/ValueReader.java#L266

sakshamgupta05 avatar Jul 09 '21 20:07 sakshamgupta05

LGTM, but maybe needs to wait for a major version bump as it's clearly going to be a Breaking Change. Although I expect many people are not running into this.

dch avatar Sep 20 '21 09:09 dch