drone-cache
drone-cache copied to clipboard
Initial Alibaba oss backend setup
Fixes #65
Proposed Changes
- add
github.com/aliyun/aliyun-oss-go-sdk/oss
dependency. - Implement Alibaba Object Storage Service backend.
- Add Alibaba OSS to plugins config
Description
Checklist
- [x] Read the CONTRIBUTING document.
- [x] Read the CODE OF CONDUCT document.
- [x] Add tests to cover changes.
- [x] Ensure your code follows the code style of this project.
- [ ] Ensure CI and all other PR checks are green OR
- [x ] Code compiles correctly.
- [ ] Created tests which fail without the change (if possible).
- [ ] All new and existing tests passed.
- [ ] Add your changes to
Unreleased
section of CHANGELOG. - [ ] Improve and update the README (if necessary).
- [ ] Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.
Hey @rugwirobaker, I will try to give this one a push this weekend or in the next week.
What's left? Do you need help with something specific?
Hey @rugwirobaker, any update on this?
@kakkoyun sorry I have been busy with other commitments. Just came back to it. Would actually appreciate help regarding testing since there all on integration tests in the backend package I assume you have to create an account with the corresponding backend service and live test? And of course documentation.
@rugwirobaker Happy to help. I've been working on a major refactoring after a couple of backends merged, in the same PR I'll be introducing an easy way to test backends. #86
I'll ping you when it's merged if you still want to continue working on it.
I'm actually working on it right now. Just have to comply with the linter and we are go.
@kakkoyun do you have any ideas on whether are alibaba-oss emulators that we can easly install into the dev/test environment? I'm thinking something like azurite.
@rugwirobaker I found this https://github.com/aliyun/oss-emulator from their official documentation https://www.alibabacloud.com/help/doc-detail/44075.html Unfortunately documentation in Chinese, however, code itself is readable. Also, there are some docker images https://hub.docker.com/search?q=oss-emulator&type=image It should work if we can figure how to run it.
What do you think?
@rugwirobaker We have changed overall structure, you may want to have a look at the latest state of master. It'd make more sense to check out a new branch and apply your changes rather than reading it.
@rugwirobaker Any plans to push this to the finish line?
@kakkoyun I'm working on it this weekend. Should have something by Sunday.
@rugwirobaker Amazing news! Go for it
Hey @rugwirobaker, do you still think we can do this?
@rugwirobaker is this still a desired addition to drone cache, or anyone else want to take ownership? Otherwise I will most likely close the pull request due within the coming weeks.
Solved by https://github.com/meltwater/drone-cache/pull/223