archive: Add absolute path mode

[hacktron95]

ALL CREDITS goes to @imranismail Fixes #130 #106 comment

Description

• add absolute path mode to tar.gz file by checking for any path prefixed with /

• add test in tar_test.gz for the absolute path mode.

• since gzip.go uses tar.gz underneath it, there was no changed made to gzip.go

• added test in gzip_test.go for the absolute path mode.

• [x] Read the CONTRIBUTING document.

• [x] Read the CODE OF CONDUCT document.

• [x] Add tests to cover changes.

• [x] Ensure your code follows the code style of this project.

• [X] Ensure CI and all other PR checks are green OR

  • [x] Code compiles correctly.
  • [x] Created tests which fail without the change (if possible).
  • [x] All new and existing tests passed.

• [x] Add your changes to Unreleased section of CHANGELOG.

• [x] Improve and update the README (if necessary).

• [x] Ensure documentation is up-to-date. The same file will be updated in plugin index when your PR is accepted, so it will be available for end-users at http://plugins.drone.io.

[kakkoyun]

@hacktron95 Thanks for the contribution. We'll have a look at it as soon as we can.

[kakkoyun]

Hey @hacktron95, sorry I think I dropped the ball on this one. I'll try to spare some time for reviewing this.

[hacktron95]

hey @kakkoyun thanks a lot for your review, I'll resolve all the suggested changes during the weekend :+1:

[hacktron95]

hey @kakkoyun, hope you are doing well!, may I ask what's the progress on this PR please? thanks

[kakkoyun]

@hacktron95 Hey, I have missed this. I'll take a look at it. Thanks for your patience!

[silvez-dh]

hello @kakkoyun. Just want to know if this PR will be still considered to be merged. Facing same issue.

Thanks!

[kakkoyun]

It's still considered. Reviews are welcome. It's been a while since the last time I have touched the project. I'll do my best to merge it, no promises. As I told additional reviews and tests would be helpful.

[umarizulkifli]

bump this PR

[ste93cry]

I think that use-cases where the paths to cache are outside of the workspace directory are quite common, e.g. when wanting to save the cache of some package managers. I am personally affected by this when trying to save the directory of the Composer cache. Is there any plan to bring this PR home anytime soon?

[mattzuba]

Echoing @ste93cry - this is preventing me from proper caching for a large number of repositories utilizing composer and npm (Node). Any chance of seeing this merged any time soon? For what it's worth, I pulled the author's repo and built it locally for testing with drone exec and it worked great for composer dependencies.

[kakkoyun]

I guess we need help from @meltwater-foundation to proceed with this

[bdebyl]

@hacktron95 Do you mind pulling the latest master into your working branch and resolving conflicts? After this and passing tests I'm happy to review and merge.

[mattzuba]

pinging @hacktron95 - can you review @bdebyl's comment from Jul 19?

[bdebyl]

@hacktron95 @mattzuba I can resolve the merge conflicts if either of you are unavailable to. That's all that's left to get this merged and ready for the v1.4.0 release

[mattzuba]

I have forked this and the other repos, rebased the commits and done some testing and I'm happy to submit a new PR if you'd like.

[hacktron95]

Hey @mattzuba @bdebyl, Sorry for my late reply I totally overlooked this thread, I've merged upstream master because my repository was forked from another fork :D so I hope I did it right.