refactor: Make `auth_headers` and `auth_params` simple attributes instead of decorated properties in the base class
The properties already default to {}, so there's no need to do it here too. The properties themselves also seem redundant - why not just use the attributes auth_headers and auth_params directly, and change them into properties in the future if they need special handling?
request.headers.update(self.auth_headers)
request.params.update(self.auth_params)
Originally posted by @WillDaSilva in https://github.com/meltano/sdk/pull/842#discussion_r953849506
This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.
Still relevant
This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.
It's odd that stalebot closes issues as completed, instead of as "not planned". @edgarrmondragon should this have been closed?
Yeah, I'd indeed prefer the latter for most of these, and I missed this one.