sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Merging parent context with partitions

Open MeltyBot opened this issue 3 years ago • 5 comments

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/273

Originally created by @vischous on 2021-11-18 21:08:22


I have a use case with tap-clickup where a stream has a parameter that we need to call for archived where we need to call (and paginate) archived=true and archived=false. This stream is also a Child stream that needs the parents ID.

This line of code shows where using both contexts and partitions together doesn't work https://gitlab.com/meltano/sdk/-/blob/v0.4.6/singer_sdk/streams/core.py#L934

We could merge these two together like I did here https://github.com/AutoIDM/tap-clickup/blob/main/tap_clickup/client.py#L126 and https://github.com/AutoIDM/tap-clickup/blob/main/tap_clickup/client.py#L114 . The problem with this implementation is my state gets messed up when it comes to incremental streams.

MeltyBot avatar Nov 18 '21 21:11 MeltyBot

Note that https://github.com/AutoIDM/tap-clickup/blob/main/tap_clickup/client.py#L116-L142 is the latest implementation of this, and state does work. There's still a little oddity with having to have partitions be set to None that could probably be fixed easily https://github.com/AutoIDM/tap-clickup/blob/main/tap_clickup/streams.py#L38-L39

visch avatar May 01 '23 13:05 visch

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

stale[bot] avatar Aug 29 '23 13:08 stale[bot]

Still relevant and accepting contributions

edgarrmondragon avatar Aug 29 '23 17:08 edgarrmondragon

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

stale[bot] avatar Aug 28 '24 18:08 stale[bot]