sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Feature: stream_name_splits toggle in targets

Open visch opened this issue 2 years ago • 3 comments

Feature scope

Targets (data type handling, batching, SQL object generation, etc.)

Description

For SQL Targets we splits streams based on dash's see https://github.com/meltano/sdk/blob/main/singer_sdk/sinks/sql.py#L67-L103 , this can be confusing for folks we aren't expecting this or who have a source like tap-dynamodb that have streams with dash's in the name by design, but the dash's do not represent <schema>-<table> . So I think we should add a flag for stream_name_splits

Example implementation here https://github.com/MeltanoLabs/target-postgres/pull/59

Slack thread: https://meltano.slack.com/archives/C01TCRBBJD7/p1671688563297449

visch avatar Jan 10 '23 21:01 visch

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

stale[bot] avatar Jul 18 '23 03:07 stale[bot]

Still relevant

edgarrmondragon avatar Jul 21 '23 16:07 edgarrmondragon

This has been marked as stale because it is unassigned, and has not had recent activity. It will be closed after 21 days if no further activity occurs. If this should never go stale, please add the evergreen label, or request that it be added.

stale[bot] avatar Jul 20 '24 16:07 stale[bot]