feat(cli): Support installing multiple plugins of any type
Closes #8353
Deploy Preview for meltano ready!
| Name | Link |
|---|---|
| Latest commit | 898f6d1cc89d319aad46043bbccd376cf167c3e7 |
| Latest deploy log | https://app.netlify.com/sites/meltano/deploys/660c289bb6ff4c0008bf1106 |
| Deploy Preview | https://deploy-preview-8355--meltano.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.60%. Comparing base (
dcf91e6) to head (898f6d1).
Additional details and impacted files
@@ Coverage Diff @@
## main #8355 +/- ##
=======================================
Coverage 91.59% 91.60%
=======================================
Files 245 245
Lines 19159 19172 +13
Branches 2138 2140 +2
=======================================
+ Hits 17549 17562 +13
Misses 1332 1332
Partials 278 278
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ReubenFrankel Should we add some docs?
@edgarrmondragon What do you think about using -- (double-dash) over - as the special "any" plugin type argument? -- is used in .lock file names as a delimiter between the plugin name and variant (e.g tap-spotify--matatika.lock), so maybe it could function similarly here? At least then there is no overlap with the Unix file argument convention using -.
EDIT: Never mind - this doesn't work.
What about ??
@ReubenFrankel Just for posterity, I'll note that with *nix CLI applications -- on its own commonly indicates that no more CLI options (of the form e.g. -n/--name) will be specified, and what remains should not be processed as such. If you're going to pass user input into a command, e.g. command "$USER_PROVIDED_VALUE", it's a best practice to use command -- "$USER_PROVIDED_VALUE" to prevent the user from providing a CLI option for the command.
@ReubenFrankel Just for posterity, I'll note that with *nix CLI applications
--on its own commonly indicates that no more CLI options (of the form e.g.-n/--name) will be specified, and what remains should not be processed as such. If you're going to pass user input into a command, e.g.command "$USER_PROVIDED_VALUE", it's a best practice to usecommand -- "$USER_PROVIDED_VALUE"to prevent the user from providing a CLI option for the command.
Ah, I thought I had seen that somewhere before - that makes sense! Thanks for the explanation.
Thanks @ReubenFrankel!