meltano icon indicating copy to clipboard operation
meltano copied to clipboard

Uvicorn - Upgrade doesn't work

Open visch opened this issue 3 years ago • 2 comments

Testing on Windows running with Uvicorn pressing the "Update" button doesn't work

visch avatar Jun 27 '22 21:06 visch

The upgrade completes in the background at least in a new python virtual environment and newly initialized project. Once the button is pushed and the upgrade is kicked off the UI seems to not detect that the upgrade has completed.

Here are the steps I used to test:

python -m venv .\.venv\meltano-previous
./.venv/meltano-previous/Scripts/Activate.ps1
pip install --upgrade pip
pip install meltano==2.0.3
meltano init --no_usage_stats test-upgrade
cd  .\test-upgrade\
meltano --version
meltano --log-level debug ui
opened UI in a browser
clicked on "Update Available" button
clicked on the "Update Meltano" button
waited 1 minute
closed the browser
ctrl+c to stop meltano ui
meltano --version

Here is the console output when I ran these steps: buzzcutnorman-meltano-ui-upgrade-20220701.log

I have noticed on Windows if the file(symbolic link) .meltano/run/bin is present in your project when you run the upgrade via meltano upgrade or the melatno ui "Upgrade Button" you will get the following WinError.

[WinError 193] %1 is not a valid Win32 application

if you remove the file and run meltano upgrade the upgrade will complete. I am not sure what the long term ramification of deleting the file is.

BuzzCutNorman avatar Jul 01 '22 21:07 BuzzCutNorman

I created a new issue #6467 for the Win32 application error and submitted a PR to fix the issue #6468 .

BuzzCutNorman avatar Jul 22 '22 21:07 BuzzCutNorman

Closing as no longer relevant on account of the removal of the UI for Meltano 3.0

WillDaSilva avatar Apr 03 '23 14:04 WillDaSilva