hub
hub copied to clipboard
meltano
feat: Show last updated badge for alternate plugin variants
Closes #1293
Happy to add "Last updated" back, but thought it looked cleaner without - or we can do something on hover as suggested in #1293.
Deploy Preview for meltano-hub ready!
| Name | Link |
|---|---|
| Latest commit | d6f0f3a2db91c746e87ee3428ce8029f2908446f |
| Latest deploy log | https://app.netlify.com/sites/meltano-hub/deploys/667a7cfe151d360008b91bff |
| Deploy Preview | https://deploy-preview-1719--meltano-hub.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
We could add the Airbyte badge back once https://github.com/badges/shields/pull/10041 is released (i.e. last commit for connector path in the repo).
I think @tayloramurphy had some concerns about the limited real-estate in the current plugin pages so I kinda wanna let him comment
@edgarrmondragon @pnadolny13 can we get the build for this working so I can see a preview? Hard to compare with just a screenshot.
Thanks for fixing the build @ReubenFrankel!
Things do seem a bit crowded on mobile:
cc @tayloramurphy
https://deploy-preview-1719--meltano-hub.netlify.app/extractors/tap-tiktok
@edgarrmondragon Ah yeah, that doesn't look amazing... I forgot about mobile.
I don't love this. The badging was an attempt to indicate overall quality - but I get why you'd just want to see the latest quick ASAP.
I like the proposal of a hover or tap to view some of the data - maybe based on the badge? @pnadolny13 what do you think?
I like the proposal of a hover or tap to view some of the data - maybe based on the badge?
@ReubenFrankel @tayloramurphy @edgarrmondragon I agree that seeing all of the variant metadata next to each other helps a lot when comparing but were running out of space. The idea of a hover sounds nice. If we had a Compare variants tool tip that would be ideal. Like put all the variants next to each other in a tabular view to compare across the board that pops up when you click. Idk how challenging these types of things are though.
I'll have a look into a tooltip implementation when I find some more time to work on this. :slightly_smiling_face:
Current state:
If we had a Compare variants tool tip that would be ideal. Like put all the variants next to each other in a tabular view to compare across the board that pops up when you click.
Wasn't quite sure how to interpret this, but sounds like it would benefit from a design first - I imagine you would want to compare across more than just last updated date, such as quality and built with the SDK (i.e. existing badges)?
I deployed a preview to https://deploy-preview-1779--meltano-hub.netlify.app/extractors/tap-purecloud but the hovers don't seem to work? @pnadolny13 any idea?
@tayloramurphy I think that deploy was targeting https://github.com/meltano/hub/commit/e78acb7ca5f406e9fe7c1751495d8842c4f40b5a, which I accidentally pushed to this branch the other day (hence previous force-push back).
https://github.com/meltano/hub/actions/runs/9428997282