Fix: `usePortal` Action

Open abdel-17 opened this issue 2 years ago • 2 comments

Problem

If usePortal is used as a Svelte action and the update() function receives an undefined target, it incorrectly throws an error rather than fallback to document.body.

Fix

This PR correctly handles this edge case by first checking if the portal target is undefined.

Feb 16 '24 13:02 abdel-17

⚠️ No Changeset found

Latest commit: 8351cd0c6b7c48435ec916f26008f78e4c1d396c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Feb 16 '24 13:02 changeset-bot[bot]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
melt-ui	✅ Ready (View Log)	Visit Preview	8351cd0c6b7c48435ec916f26008f78e4c1d396c

Feb 16 '24 15:02 github-actions[bot]

Rejecting because of changes upstream. Will fix it

May 31 '24 09:05 TGlide