Melroy van den Berg
Melroy van den Berg
Queued the ci
Tests are failing..
If you wish to get this PR merged, it might be better to not make unnecessary changes like removing code from the unit test. Unrelated changes can better be done...
I'm unsure... See: https://stackoverflow.com/questions/74508024/is-requirements-txt-still-needed-when-using-pyproject-toml > My current assumption is: [...] you put your (mostly unpinned) dependencies to pyproject.toml instead of setup.py, so you library can be installed as a dependency...
I won't merge this pr indeed. It's not correct. @cdce8p feel free to open a new pr with a smaller change scope and I have the feeling you have more...
> I'm happy to revise the PR that was left unreviewed, many thanks for your revision @cdce8p . > > After all the effort I made and the review, having...
It took 1 hour 28 minutes.
Outputs says.. Maybe because the file didn't change upstream? I dunno actually..  It says "updated pr"
> If weekly becomes an issue, we can see what to do. I would personally like to see monthly. Which is still more than enough imo. What do you think?
@sebastian-correa Anyhow, it doesn't seem to "update" the PR. Maybe because it not needed?