Melroy van den Berg
Melroy van den Berg
memory leak with Rust!? W000t. Do not panic, I think you use unsafe here.
Why is this on hold?
@helveticadomes Well, yes this will solve the fact you solely have a date. But now you can't support date + time (which should also be possible in some cases) :cry:...
Ah the name parser was also wrong. So the order was indeed wrong regarding lastname, firstname and additional. It's also a best practice to add some additional unit testers with...
@helveticadomes I changed my unit tester on the dev branch, can you pull the new changes from 2.0.0-dev? So I can validate the FN outcome.
> **it is implemented that:** > if FN exist and N exist => keep both and do nothing to them > if FN exist but N dont exist => keep...
is it a good idea to also **add** a correct vcard file to assets? With correct I mean define the `FN:`. https://github.com/helveticadomes/vcard/blob/feature-fixed-name-property/tests/assets/vcard.vcf We can keep the current vcard asset as...
> lack of knowledge that describe exactly me :-D (git/github/travis) > if i assume right something need to be added to VCardTest.php because FN is added if only N exist....
I fixed the testcases, found yet another bug in the `DateTimeOrStringValue` class. regarding the `__toString()` method. The 'u' format (see Date format in php docs) will return zero's with a...