melonDS icon indicating copy to clipboard operation
melonDS copied to clipboard

Fix: Some errors in Ram Search

Open 2jun0 opened this issue 2 years ago • 2 comments

This article was written with the help of a translator. Please let me know if you have any problems understanding

🛠 Fix some errors

Avoiding too many memory updates (#1406)

Each time a row in the table was updated, the RAM was updated. So accessing memory that is frequently modified will break your program.

Currently the RAM is updated when the user changes the value.

Fixed error that some rows are partially invisible in mac (like below)

image

Fixed an error where rows were accumulated

There was an error where existing information was accumulated even when searching for a new one.

📌 Others

Updated default search byte type from One to Four.

2jun0 avatar Nov 06 '22 14:11 2jun0

I was having some crashing issues in melonDS and tried your fix hoping it would solve my problme. However, I still get a crash on opening RAM Search while in-game playing Animal Crossing: Wild World:

terminate called after throwing an instance of 'std::out_of_range'
  what():  vector::_M_range_check: __n (which is 2147483628) >= this->size() (which is 4194304)

Would you like me to help you debug this further? Thanks for trying, at the very least!!

TheGag96 avatar Mar 13 '23 00:03 TheGag96