melonDS icon indicating copy to clipboard operation
melonDS copied to clipboard

Published 20 hours ago • verified publisher icon melonDS-emu

Wifi: Fix -Wformat

Open carmiker opened this issue 1 year ago • 2 comments

This PR fixes -Wformat warnings.

The first change adds what I believe is the correct variable to the printf statement -- there is one less argument than there should be.

The other changes may be architecture dependent. I am on a musl-based Linux amd64 distro.

carmiker avatar Oct 14 '22 23:10 carmiker

The other changes would be wrong on Windows where long is 32 bits rather than 64 bits. long long is needed for 64 bits on Windows (and would be fine on Linux anyways as that's also 64 bits, more just a silly warning). You probably could just cast the variable to unsigned long long to supress the warning on Linux.

CasualPokePlayer avatar Oct 14 '22 23:10 CasualPokePlayer

@CasualPokePlayer I've just force pushed to only include the first fix.

carmiker avatar Oct 15 '22 02:10 carmiker

@Arisotura @nadiaholmquist any thoughts?

carmiker avatar Dec 10 '22 20:12 carmiker

This fixes a QA notice on Gentoo, can it please be merged?

orbea avatar Dec 30 '22 18:12 orbea